Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39581 )
Change subject: src/soc/intel/jasperlake: Update SD card ACPI device ......................................................................
Patch Set 5:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 95: If (LEqual (Arg0, DSUU)) {
Yes.
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 97: LGreaterEqual (Arg1, Zero)
Arg1 >= 0
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 115: LEqual (Arg2, Zero)
Arg2 == 0
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 125: LEqual (Arg2, 3)
Arg2 == 3
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 136: LEqual (Arg2, 4)
Arg2 == 4
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 159: And (PMCR, 0xFFFC, PMCR)
PMCR = PMCR & 0xFFFC
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 160: Store (PMCR, TEMP)
TEMP = PMCR
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 171: Or (PMCR, 0x0003, PMCR)
PMCR = PMCR | 0x0003
Done
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 172: Store (PMCR, TEMP)
TEMP = PMCR
Done