Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Avoid value overwritten before its usage ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Maybe mention, that currently the (negative) return value does not seem to matter.
Would a follow-up be good to print the value in the debug message?
if (rv < 0) printk(BIOS_DEBUG, "usbdebug: Failed hardware init\n");
There's a Kconfig option to debug console initialisation. Plus, if the console was unable to initialise, why print a message?
There could be working other consoles like serial console.
I think there's a message like that already.
Sorry for the misunderstanding. I meant extending the current message.