Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46324 )
Change subject: soc/intel/broadwell: Revise SA lockdown sequence ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46324/6/src/soc/intel/broadwell/fin... File src/soc/intel/broadwell/finalize.c:
https://review.coreboot.org/c/coreboot/+/46324/6/src/soc/intel/broadwell/fin... PS6, Line 29: REG_MMIO_OR32(MCH_BASE_ADDRESS + 0x5f00, 1 << 31), /* SA PM */
What happens here?
This register was dropped from the lockdown sequence and doesn't have a lock bit since haswell.
https://review.coreboot.org/c/coreboot/+/46324/6/src/soc/intel/broadwell/fin... PS6, Line 16: /* : * 16.6 System Agent Configuration Locking : * "5th Generation Intel Core Processor Family BIOS Specification" : * Document Number 535094 : * Revision 2.2.0, August 2014 : */
To be helpful, this needs additional comments when and why we deviate from […]
Agreed.