[coreboot-gerrit] Change in coreboot[master]: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )

Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
File src/soc/intel/apollolake/romstage.c:

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
PS7, Line 259: PrimaryVideoAdaptor
> I assume it configures decoding of legacy VGA cycles. And it is actually […]

For Skylake AUTO is equivalent to IDG. I don't think that in our case intel did differently.

I suggest adding an option to install this from the devicetree, as was done earlier ( https://review.coreboot.org/c/coreboot/+/39374/1/src/soc/intel/apollolake/ro... ) to configure this from the board configuration.

I will try to test when I can get to the office but it just will not be soon. I'll try to connect a graphics card through the mini PCIe -> PCIe x1 slot adapter.