Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44028 )
Change subject: soc/intel/skylake: Enable SDXC depending on devicetree configuration
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44028/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44028/2//COMMIT_MSG@10
PS2, Line 10: but this duplicates the devicetree on/off options. Therefore use the
: on/off options for the enablement of the SDXC controller.
:
... depend on the devicetree for enablement ...
https://review.coreboot.org/c/coreboot/+/44028/2//COMMIT_MSG@14
PS2, Line 14: matches the ScsSdCardEnabled setting.
and addded missing entries
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44028
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I298b7d0b0fe2a7346dbadcea4be22dc67fce4de8
Gerrit-Change-Number: 44028
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Jul 2020 08:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment