Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32546 )
Change subject: qcom: Add i2c driver ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c File src/soc/qualcomm/qcs405/blsp.c:
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c@45 PS5, Line 45: clock_configure_i2c(19200000);
I understand this wrt the fix use case of one i2c instance. […]
Don't think there will be on mistral, but I'd hope we can reuse the work we're doing here :-) clock_configure_i2c was defined in a CL that is already merged, so you'll have to edit the existing implementation. Feel free to do that to pass along the BLSP_QUP.
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c@56 PS5, Line 56: 1
Ok we will add the check for id at the beginning of the API. […]
Makes sense. Let's keep the id argument, but test earlier (before half of the configuration is done) if it's valid for the current code.