Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 75:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... PS62, Line 51: config ONBOARD_VGA_IS_PRIMARY
This means that, by default, a VBIOS for the iGPU needs to be added. […]
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... PS66, Line 60: pirq_info = (void *)(&pirq->checksum + 1);
that's just taking the address of "pirq->slots" in a rather fragile way
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... PS66, Line 73: v[i]
Ah, I see: this is used to read the bytes for checksumming purposes. […]
Done