Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42832 )
Change subject: mb/google/zork: Add Bluetooth reset gpios to devicetree ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42832/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42832/9//COMMIT_MSG@11 PS9, Line 11: specfic nit: specific
https://review.coreboot.org/c/coreboot/+/42832/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/42832/9/src/mainboard/google/zork/v... PS9, Line 320: #if !DEVTREE_EARLY I think this whole block can be moved to ramstage_common.c. Then you won't need the guard for DEVTREE_EARLY and the function `baseboard_remove_bluetooth_reset_gpio()` doesn't need to exposed outside the file scope.
https://review.coreboot.org/c/coreboot/+/42832/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/42832/9/src/mainboard/google/zork/v... PS9, Line 38: audio nit: bluetooth