Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Werner Zeh, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61520 )
Change subject: soc/intel/common/cse: Add function to perform global reset lock ......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/61520/comment/b4ca629c_8c75058f PS8, Line 1022: if (cse_is_hfs1_spi_protected())
Also, isn't that you said, CSE update doesn't bother about global reset using PMC rather use MEI msg. Plus, it doesn't wait for so long to ensure CSE update.
Hence, recommendation is global reset is remain locked for CSE Lite irrespective of HFSTS1 state.
Any pointer to about who shares this recommendation and in what form ? I mean any document as such.
I'm still fine since the change has no impact on production systems wherein global reset is always locked.
Note, `if clause` is about locking the CF9Lock and `else` is about keep the CF9 unlock to allow global reset. What you have asked originally at starting of this thread as below is against what you just said here.
You have asked to skip locking the CF9Lock in case SoC user selects CSE LITE SKU.
if (cse_cse_is_hfs1_spi_protected() && !CONFIG(CONFIG_SOC_INTEL_CSE_LITE_SKU)
And, in above comment you said, the recommendation is global reset remain locked for CSE lite? then why to leave the CF9Lock unlock for CSE Lite SKU?