Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )
Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1 ......................................................................
Patch Set 4: Code-Review-1
(5 comments)
This function is called nowhere?
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... File src/drivers/intel/fsp1_1/logo.c:
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 19: static static needed?
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 20: = 0; not needed as initialized static.
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 26: !logo_data_sz why? do you expect to call this function multiple times?
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 31: params->PcdLogoSize check the return value logo_data_sz instead of this.
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 36: return; unneeded?