Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34976 )
Change subject: cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK ......................................................................
Patch Set 2:
(1 comment)
Maybe you can move the guards upwards here too, 256 above _car_stack_start ?
https://review.coreboot.org/c/coreboot/+/34976/2/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34976/2/src/cpu/intel/car/romstage.... PS2, Line 30: const u32 max_dcache_stack_size = CONFIG_DCACHE_BSP_STACK_SIZE ? Better:
const size_t stack_size = MAX(CONFIG_DCACHE_BSP_STACK_SIZE, 0x2000);