Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34993 )
Change subject: arch/x86: Include cbmem region into postcar_frame
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34993/2/src/arch/x86/include/arch/c...
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/34993/2/src/arch/x86/include/arch/c...
PS2, Line 303: uintptr_t cbmem_top;
: size_t cbmem_size;
Extending the struct seems unnecessary, just call cbmem_top() and cbmem_overhead_size() where you need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2ded90f4faa5d4996f3aefb4da9083a42e0aa8
Gerrit-Change-Number: 34993
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Nov 2019 13:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment