William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant ......................................................................
Patch Set 6: -Code-Review
(12 comments)
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 83: DN_20K
Why?
The full table copy from Ripto, and Ripto used DN_20K. I'll change to NONE to match baseboard settings.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 91: DN_20K
Why is this PD added?
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 101: DN_20K
Why PD?
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 108: DN_20K
Same here.
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 173: DN_20K
Same here.
GPP_D10 has a similar function with GPP_D12, and we see the GPP_D12 also use a DN_20K, so we add it here. If you think NC pin do not use this, I'll change it to NONE.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 177: DN_20K
Same here.
Baseboard also has a DN_20K with NF7, we follow the settings here. If you think NC pin do not use this, I'll change it to NONE.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 232: DN_20K
Why does this have an internal PD?
The full table copy from Ripto, and Ripto used DN_20K. I'll change to NONE to match baseboard settings.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 257: DN_20K
Same here.
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 291: DN_20K
Same here.
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 293: DN_20K
and here.
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 295: DN_20K
and here.
Same reason.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 348: DN_20K
Why?
Same reason.