Attention is currently required from: Kane Chen, Kapil Porwal, Pratikkumar V Prajapati, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78259?usp=email )
Change subject: commonlib/bsd: Get rid of CBMEM IDs for crashlog
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
As long as anyone has ever used firmware that creates spaces with these IDs, we shouldn't remove them so that the `cbmem` utility can still show them when running on those older platforms. You can rename them to something that contains DEPRECATED in the name and/or add a comment that they are deprecated next to the definition if you want to mark that they should no longer be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78259?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie38571dece89a995d582099d34f0a1dd57cb936f
Gerrit-Change-Number: 78259
Gerrit-PatchSet: 2
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 21:41:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment