Attention is currently required from: Michał Żygowski, Martin L Roth, Benjamin Doron, Paul Menzel, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378 )
Change subject: drivers/smm_payload_interface: Add initial support for SMM payload
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70378/comment/78d2bca0_d4e3b9d8
PS11, Line 34: The solution here is to initialise SMM in EDK2, following UefiPayload
Mention that is limited to a subset of Intel platforms.
File Documentation/drivers/s3_save_restore.md:
https://review.coreboot.org/c/coreboot/+/70378/comment/061fa34f_8180c73a
PS8, Line 8: with differing register definitions
Everything a recent Intel platform needs to globally enable SMIs (and lock this), and enable the 0xB […]
How does your implementation (this patchset) support many silicon generations with differing register definitions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dd505a154175b6da8929b1157723de1645ca8fa
Gerrit-Change-Number: 70378
Gerrit-PatchSet: 11
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 27 Feb 2023 07:31:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment