build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27766 )
Change subject: soc/intel/cannonlake: Update UPD from device switch ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c File src/soc/intel/cannonlake/chip.c:
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c@253 PS4, Line 253: params->Usb2AfePredeemp[i] = config->usb2_ports[i].tx_emp_enable; line over 80 characters
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c@262 PS4, Line 262: params->Usb3HsioTxDeEmph[i] = config->usb3_ports[i].tx_de_emp; line over 80 characters
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c@266 PS4, Line 266: params->Usb3HsioTxDownscaleAmp[i] = config->usb3_ports[i].tx_downscale_amp; line over 80 characters
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c@295 PS4, Line 295: params->PchScsEmmcHs400RxStrobeDll1 = config->EmmcHs400RxStrobeDll1; line over 80 characters
https://review.coreboot.org/#/c/27766/4/src/soc/intel/cannonlake/chip.c@296 PS4, Line 296: params->PchScsEmmcHs400TxDataDll = config->EmmcHs400TxDataDll; line over 80 characters