[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/icelake_rvp: Add SMI handlers

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32252 )

Change subject: mb/intel/icelake_rvp: Add SMI handlers
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/32252/4/src/mainboard/intel/icelake_rvp/smih... 
File src/mainboard/intel/icelake_rvp/smihandler.c:

https://review.coreboot.org/#/c/32252/4/src/mainboard/intel/icelake_rvp/smih... 
PS4, Line 4:  * Copyright (C) 2018 Intel Corporation.
> 2019

Done

https://review.coreboot.org/#/c/32252/4/src/mainboard/intel/icelake_rvp/smih... 
PS4, Line 23: #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
> CONFIG( […]

It is interfaced via add in card. so with the AIC , the chromeec config needs to be selected.