Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM)
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42078/9/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/9/src/ec/google/chromeec/ec.c...
PS9, Line 1490: *port_map = resp.reserved;
so should I just hard code it for now? since it's in mainboard there really isn't a downside to just […]
Either hardcode it now and I'll go back and fix it up later when the alias patchset lands, or you could rebase it on top of the current end of the set: https://review.coreboot.org/c/coreboot/+/45939
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If994a459288ef31b0e6da8c6cdfd0ce3a0303981
Gerrit-Change-Number: 42078
Gerrit-PatchSet: 14
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Comment-Date: Fri, 02 Oct 2020 19:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment