Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Fix - Remove unused variables
......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/#/c/29917/23/src/soc/intel/fsp_baytrail/romstage...
File src/soc/intel/fsp_baytrail/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/23/src/soc/intel/fsp_baytrail/romstage...
PS23, Line 253: if (!cbmem_was_initted)
: printk(BIOS_ERR, "cbmem init failed\n");
unrelated to description
If the variable is not used, can't the cbmem_recovery function be called without saving the result to a variable? I feel adding this printf is a hack to make the variable used somewhere, which does not seem wise to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 23
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 17 Jan 2019 00:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment