Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49059 )
Change subject: mb/{google,intel}/*: select SOC_INTEL_CSE_LITE_SKU only if CHROMEOS ......................................................................
mb/{google,intel}/*: select SOC_INTEL_CSE_LITE_SKU only if CHROMEOS
Selecting SOC_INTEL_CSE_LITE_SKU without conditioning on CHROMEOS force-selects CHROMEOS, per src/soc/intel/common/block/cse/Kconfig.
Conditioning on CHROMEOS allows for non-ChromeOS targets to be built.
Change-Id: I6959f35e1285b2fab7ea1f83a5ccfcb065c12397 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/volteer/Kconfig.name M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/tglrvp/Kconfig 4 files changed, 17 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/49059/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 94a0a90..6e5650d 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -25,7 +25,7 @@ select MAINBOARD_HAS_TPM2 select SOC_INTEL_JASPERLAKE select SOC_INTEL_COMMON_BLOCK_DTT - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select HAVE_SPD_IN_CBFS if !BOARD_GOOGLE_DEDEDE select DRIVERS_INTEL_MIPI_CAMERA select SOC_INTEL_COMMON_BLOCK_IPU diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8777994..9c79c2e 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -3,24 +3,24 @@ config BOARD_GOOGLE_DELBIN bool "-> Delbin" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select DRIVERS_GENESYSLOGIC_GL9755
config BOARD_GOOGLE_ELDRID bool "-> Eldrid" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config BOARD_GOOGLE_HALVOR bool "-> Halvor" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM
config BOARD_GOOGLE_LINDAR bool "-> Lindar" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -28,38 +28,38 @@ config BOARD_GOOGLE_MALEFOR bool "-> Malefor" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM
config BOARD_GOOGLE_TERRADOR bool "-> Terrador" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config BOARD_GOOGLE_TODOR bool "-> Todor" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM
config BOARD_GOOGLE_TRONDO bool "-> Trondo" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM
config BOARD_GOOGLE_VOLTEER bool "-> Volteer" select BOARD_GOOGLE_BASEBOARD_VOLTEER select VARIANT_HAS_MIPI_CAMERA - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select INTEL_CAR_NEM
config BOARD_GOOGLE_VOLTEER2 bool "-> Volteer2" select BOARD_GOOGLE_BASEBOARD_VOLTEER select VARIANT_HAS_MIPI_CAMERA - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select DRIVERS_GENESYSLOGIC_GL9755 select DRIVER_I2C_TPM_ACPI
@@ -68,14 +68,14 @@ bool "-> Volteer2_Ti50" select BOARD_GOOGLE_BASEBOARD_VOLTEER select VARIANT_HAS_MIPI_CAMERA - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select DRIVERS_GENESYSLOGIC_GL9755 select DRIVER_I2C_TPM_ACPI
config BOARD_GOOGLE_VOXEL bool "-> Voxel" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config BOARD_GOOGLE_BOLDAR bool "-> Boldar" @@ -85,13 +85,13 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config BOARD_GOOGLE_VOEMA bool "-> Voema" select BOARD_GOOGLE_BASEBOARD_VOLTEER select VARIANT_HAS_MIPI_CAMERA - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config BOARD_GOOGLE_DROBIT bool "-> Drobit" diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 7bfd158..eb63834 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -20,7 +20,7 @@ select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_JASPERLAKE select SOC_INTEL_COMMON_BLOCK_DTT - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS
config MAINBOARD_DIR string diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 9df542d..24f990c 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -20,7 +20,7 @@ select EC_ACPI select PCIEXP_HOTPLUG select HAVE_SPD_IN_CBFS - select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_LITE_SKU if CHROMEOS select MAINBOARD_HAS_TPM2 select MAINBOARD_HAS_SPI_TPM_CR50 select SPI_TPM