Attention is currently required from: Paul Menzel, Iru Cai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46630 )
Change subject: mb/hp: Add EliteBook 820 G2 ......................................................................
Patch Set 8:
(2 comments)
File Documentation/mainboard/hp/elitebook_820_g2.md:
https://review.coreboot.org/c/coreboot/+/46630/comment/993362e2_69b810ee PS8, Line 102: - NFC module : - Fingerprint reader : - Smart Card reader : - TPM If you have these devices, do they at least show up in the OS? (e.g. lsusb)
File src/mainboard/hp/elitebook_820_g2/gpio.c:
https://review.coreboot.org/c/coreboot/+/46630/comment/3b4959f6_f1f62105 PS8, Line 6: GPIO_IRQ_LEVEL I'm a bit suspicious of these IRQ level settings without IRQ enable. Maybe these are unused.
GPIO6, GPIO41 and GPIO42 are enabled as GPEs (see devicetree)