Attention is currently required from: Furquan Shaikh, Julius Werner, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56577 )
Change subject: lib/cbfs: Add HAVE_CBFS_CACHE Kconfig
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think this makes sense. […]
When I add the CBFS_CACHE() entry to the memlayout, ramstage reports the correct value:
```
coreboot-4.14-2248-ga3f9b16e0549-dirty Thu Oct 14 16:53:49 UTC 2021 ramstage starting (log level: 8)...
RX: main: cbfs_cache->size: 8192
```
What is the behavior when linking with an external that doesn't exist?
__weak extern u8 _##name##_size[];
If I never add the CBFS_CACHE() region to the memlaytout, that symbol is undefined right? Shouldn't it cause a linker error? Or is it expecting the module loader to take care of updating the pointer?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74434ef9250ff059e7587147b1456aeabbee33aa
Gerrit-Change-Number: 56577
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 14 Oct 2021 20:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment