[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: set temperature threshold for PCH Thermal Sensor

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/cannonlake: set temperature threshold for PCH Thermal Sensor
......................................................................

Patch Set 10:

general suggestion, looks like this CL is similar to what we has in SKL/KBL here https://review.coreboot.org/22419

now it we decided to have such files in CNL and may be going forward every core design then why don't we move generic implementation into "src/soc/intel/common/pch/thermal". this code block meant for all common PCH started from gen6