Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44829 )
Change subject: mb/pcengines/apu2/mainboard.c: Use 'PCI_BASE_ADDRESS_0' instead of magic number ......................................................................
mb/pcengines/apu2/mainboard.c: Use 'PCI_BASE_ADDRESS_0' instead of magic number
Change-Id: I21378acd6408a4fae5600a54a41f695e54221dc2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44829 Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/pcengines/apu2/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index 939f7cb..40941db 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -292,7 +292,7 @@ return serial;
/* Read in the last 3 bytes of NIC's MAC address. */ - bar10 = pci_read_config32(dev, 0x10); + bar10 = pci_read_config32(dev, PCI_BASE_ADDRESS_0); bar10 &= 0xFFFE0000; bar10 += 0x5400; for (i = 3; i < 6; i++) {