Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38694 )
Change subject: soc/amd/picasso: Move BERT region to cbmem
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38694/7/src/soc/amd/picasso/mca.c
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/38694/7/src/soc/amd/picasso/mca.c@2...
PS7, Line 202: 0
nit: Use NULL so it's clear it's a pointer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4759154d394a8f5b35c0ef0a15994bbef25492e5
Gerrit-Change-Number: 38694
Gerrit-PatchSet: 7
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Apr 2020 15:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment