Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39710 )
Change subject: soc/intel/tigerlake: unlock RTC memory
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39710/6/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39710/6/src/soc/intel/tigerlake/fsp...
PS6, Line 112: params->RtcMemoryLock = 0;
On other Intel platforms, we have followed the model of checking get_lockdown_config() before setting RtcMemoryLock, PchLockDownBiosLock and other locks. Any reason TGL isn't following the same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63cec8a718285f424914e426d0399ed821588dfd
Gerrit-Change-Number: 39710
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Apr 2020 00:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment