HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30799 )
Change subject: nb/intel/i945/udelay: Use get_ia32_fsb()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30799/2/src/northbridge/intel/i945/udelay.c
File src/northbridge/intel/i945/udelay.c:
https://review.coreboot.org/#/c/30799/2/src/northbridge/intel/i945/udelay.c@...
PS2, Line 37: d = (fsb * divisor);
Should `fsb` be renamed to denote the unit?
probably not.
there is a comment here src/include/cpu/intel/fsb.h to explain what it is.
Please advise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dcc9c9f1646c8d89f45de914eb1a431ef4bef2b
Gerrit-Change-Number: 30799
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Jan 2019 12:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment