[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/uart: Restrict scope of uart_common_init to uart.c

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49211 )

Change subject: soc/intel/common/uart: Restrict scope of uart_common_init to uart.c
......................................................................

soc/intel/common/uart: Restrict scope of uart_common_init to uart.c

uart_common_init is not used outside of
soc/intel/common/block/uart.c. This change restricts the scope to this
file and drops the declaration from uart.h

Change-Id: I499a53506f9b2e91ecc7334bf9b023d342e802fc
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49211
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Angel Pons 
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/common/block/include/intelblocks/uart.h
M src/soc/intel/common/block/uart/uart.c
2 files changed, 1 insertion(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h
index 87fdf68..fd65f4c 100644
--- a/src/soc/intel/common/block/include/intelblocks/uart.h
+++ b/src/soc/intel/common/block/include/intelblocks/uart.h
@@ -24,12 +24,6 @@
  */

/*
- * Common routine to initialize UART controller PCI config space, take it out of
- * reset and configure M/N dividers.
- */
-void uart_common_init(const struct device *dev, uintptr_t baseaddr);
-
-/*
  * Check if UART debug controller is initialized
  * Returns:
  * true = If debug controller PCI config space is initialized and device is
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 75c16d4..1e205ef 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -58,7 +58,7 @@
    return UART_CONSOLE_INVALID_INDEX;
 }

-void uart_common_init(const struct device *device, uintptr_t baseaddr)
+static void uart_common_init(const struct device *device, uintptr_t baseaddr)
 {
 #if defined(__SIMPLE_DEVICE__)
    pci_devfn_t dev = PCI_BDF(device);