build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33737 )
Change subject: device/oprom: Add vbe return status support as per VBE spec 3.0 ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c@244 PS1, Line 244: printk(BIOS_DEBUG,"Supported Video Mode list for OpRom are:\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c@245 PS1, Line 245: do that open brace { should be on the previous line
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c@249 PS1, Line 249: printk(BIOS_DEBUG,"%x\n", mode); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c@280 PS1, Line 280: vbe_return_status = *((unsigned int*)REALMODE_BASE); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33737/1/src/device/oprom/realmode/x86.c@299 PS1, Line 299: printk(BIOS_DEBUG, "User to select mode from below list - \n"); unnecessary whitespace before a quoted newline