Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34710 )
Change subject: soc/intel/{cnl,icl}: Add provision to use PIRX PCI IRQ acpi package
......................................................................
Patch Set 2:
Patch Set 1:
why do you keep the old static IRQ entries?
PIRX is only created when SOC would select the IRQ configuration config. IF PIRX is not present the IRQ config is not created using irq common driver and needs to fallback to static package.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib23e57d3ce58406f8faff18e912b78a911e50d3d
Gerrit-Change-Number: 34710
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 06:50:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment