Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@16 PS1, Line 16: only Stoneyridge is combo capable
The spec says Stoney and PF should support using either 0x10 or 0x14. […]
Ok, so I'll fix code and here.
https://review.coreboot.org/c/coreboot/+/36823/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/2//COMMIT_MSG@13 PS2, Line 13: Stoneyridge
Use "Stoney Ridge" when using the code name.
Will do.
https://review.coreboot.org/c/coreboot/+/36823/2//COMMIT_MSG@16 PS2, Line 16: only Stoneyridge is combo capable.
I still believe this sounds incorrect.
Will fix.
https://review.coreboot.org/c/coreboot/+/36823/2/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36823/2/src/soc/amd/stoneyridge/Mak... PS2, Line 140: && ($(CONFIG_HAVE_MERLINFALCON_BINARIES),y))
Need to nest it
How? ifeq ($(CONFIG_SOC_AMD_MERLINFALCON)$(CONFIG_HAVE_MERLINFALCON_BINARIES),y) Does not look correct, just one y would trigger it, I want both.