Hash Hung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37247 )
Change subject: mb/google/octopus: Create Lick variant
......................................................................
Patch Set 6:
Patch Set 3:
Hi Hash,
For overall, please:
- since Lick will only have one SKU, please help to check and change/remove the code not necessary - check what's the Lick's SKU define and decide which code should be used for Lick.
- please check the Lick's component vendor source for what's the source of code related component, please remove the unused code (of unused vendor) accordingly. in case of new parts, you can add it later after AVL approved.
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If732d94194defb9f5ee9c847ee93dd58aef01174
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 6
Gerrit-Owner: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Regan Chang
regan.chang@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Thu, 28 Nov 2019 05:58:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment