[coreboot-gerrit] Change in coreboot[master]: soc/intel/{apl,cnl,dnv,icl,skl}: Move lpc.asl into common/block/acpi

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36455 )

Change subject: soc/intel/{apl,cnl,dnv,icl,skl}: Move lpc.asl into common/block/acpi
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36455/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi/lpc.asl:

https://review.coreboot.org/c/coreboot/+/36455/6/src/soc/intel/common/block/... 
PS6, Line 20:
> Curious about some of the legacy devices here:
> There is a forbidden list that Linux kernel maintains https://github.com/torvalds/linux/blob/master/drivers/acpi/acpi_platform.c#L.... Does it mean that these should not be exposed by the BIOS?

not sure in which context this "forbidden" word been used in lunux kernel list. But those devices are just added to maintain the legacy support since some time now. Even I was looking at UEFI bios code from could see the same devices.

btw, running cycle test over 2 days now will continue to run this weekend before merging CLs
> There are some HIDs that are not enumerated at all by the kernel. Are these added because they are used by other OSes?

as we are moving towards common code hence added the full supported list but i don't think all OS will bind this full device list