Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40736 )
Change subject: mb/cedarisland_crb: rework GPIOs configuration using macros
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris...
File src/mainboard/intel/cedarisland_crb/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris...
PS5, Line 14: _PAD_CFG_STRUCT(GPP_A0, 0x44000d02, 0x00000010),
See commets in CB:40731
Ack
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris...
PS5, Line 14: PAD_CFG_NF_BUF_TRIG
Unfortunately, we cannot use the PAD_CFG_NF() macro here because it sets the trig parameter to LEVEL […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id671a9021a8313d8c3359b89c2934b929bcab1a4
Gerrit-Change-Number: 40736
Gerrit-PatchSet: 7
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Apr 2020 22:07:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment