Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38400 )
Change subject: soc/mediatek/mt8183: reduce the hbp and hfp for phy timing ......................................................................
Patch Set 2:
(8 comments)
Please test and verify this on real kukui units.
https://review.coreboot.org/c/coreboot/+/38400/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38400/2//COMMIT_MSG@17 PS2, Line 17: Add
BUG=b:144824303 BRANCH=kukui TEST=Boots and sees firmware screen on krane and jacuzzi
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 78: (8 * 1000) 8000
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 79: 4 * 1000 4000
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 80: 10 * 1000 10000
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 85: + 2 no need to do / 2?
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 86: 4 * phy_timing->lpx; Are you sure the new value will still work for both MIPI (krane) and EDP (jacuzzi)?
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 93: (8 * 1000) 8000
https://review.coreboot.org/c/coreboot/+/38400/2/src/soc/mediatek/common/dsi... PS2, Line 213: hfp_byte + hbp_byte) this is repeated 3 times so let's make a variable for it, for example:
u32 total_bytes = hfp_byte + hbp_byte;