Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44381 )
Change subject: soc/ti/am335x: Fix MLO build
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44381/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44381/2//COMMIT_MSG@20
PS2, Line 20: datasheet
Where can this be retrieved? It’d be great if you mentioned the name and revision.
Good point, have added the name and revision.
https://review.coreboot.org/c/coreboot/+/44381/2//COMMIT_MSG@22
PS2, Line 22: from MLO
Nit: Just once space.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I514d7cda65ddcbf27e78286dc6857c9e81ce6f9e
Gerrit-Change-Number: 44381
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Lewis
sam.vr.lewis@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 07:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment