Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi...
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi...
PS3, Line 369: // USB MUX Interrupt
: Method (_Q1C, 0, NotSerialized)
: {
: Store ("EC: USB MUX", Debug)
: Notify (CREC, 0x80)
: }
During the TCSS bring up in ICL, I had to implement this _Q1C method to get cros_ec_lpc_acpi_notify( […]
Got it. Thanks for the context!
Do you know what on the EC is calling _Q1C ? Is it the virtual MUX driver code? https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1340491/...
I think the solution suggested in Comment #373 is a good one while we wait for all the EC/AP API changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3a2f829a295f090a03e72e12f19ecc5bb724952
Gerrit-Change-Number: 40024
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-CC: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Comment-Date: Fri, 03 Apr 2020 00:08:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Comment-In-Reply-To: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-MessageType: comment