[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/gspi: Check device validity before setting state

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34761 )

Change subject: soc/intel/common/gspi: Check device validity before setting state
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34761/1/src/soc/intel/common/block/... 
File src/soc/intel/common/block/gspi/gspi.c:

https://review.coreboot.org/c/coreboot/+/34761/1/src/soc/intel/common/block/... 
PS1, Line 482: 	if (device)
> Actually, looking at this closer, it's probably safest to put this right after setting device (line  […]

Right. In fact, the control should never get here if the device we care about isn't enabled in coreboot. So, there seems to be brokenness at a different layer. Though I agree that we should have the check here and return early with an error print indicating that this condition has occurred.