HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31416/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/1/src/arch/x86/smbios.c@385
PS1, Line 385: /* As a work around to prevent a compiler error, temporarily specify
: * 16 MiB flash sizes when ROM size >= 16 MiB. An update is necessary
: * once the SMBIOS specification addresses ROM sizes > 16 MiB.
: */
Why duplicate the comment?
oops :)
thank you so mush
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec35c8c66210f0ddc07a2ca6f976a1f8fc53037d
Gerrit-Change-Number: 31416
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 Feb 2019 13:28:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment