Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37591 )
Change subject: mb/google/hatch/variant/hatch: Config MEM_STRAP GPIOs ......................................................................
Patch Set 1:
(2 comments)
Thanks for the review, PTAL.
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG@9 PS1, Line 9: Hatch always used the default MEM_STRAPs in baseboard.
That has been intentional.
I know however the assumptions already encoded in baseboard for all variants to be laptop/tablets has been superseeded. This is addressed in the follow up:
https://review.coreboot.org/c/coreboot/+/36988
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG@10 PS1, Line 10: in the event that MEM_STRAP is set : differently in the baseboard gpio file
That would be a problem in general with any GPIO. […]
This is not unlike commit 5a0edcbde153 (https://review.coreboot.org/c/coreboot/+/37106) and fixed in https://review.coreboot.org/c/coreboot/+/37589 ..
The only reason why this series focuses on memstrap in particular is because I wanted to deal with one functional element of gpio mux changes across variants at a time not change them all at once. The memstrap muxing is a primary case of assumptions made in baseboard that no longer generalise across all variants, in fact not all variants even have the same muxing.