Attention is currently required from: Derek Huang, Eric Lai, Ivan Chen, Jamie Chen, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80769?usp=email )
Change subject: mb/google/brya/var/omniknight: remove Implement touchscreen power sequencing
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80769/comment/fd1a2fdf_3de58536 :
PS3, Line 9: For TP_EN has a abnormal peek pull high before BL_EN.
What does the touchscreen power sequencing have to do with the touchpad enable? What's the actual issue here?
Patchset:
PS3:
Removing the touchscreen power sequencing while leaving the "generic.detect" register(s) set in devicetree will result in the touchscreen being disabled due to no ACPI being generated.
Without visibility into the bug, this workaround makes no sense, and will result in the touchscreen being unusable outside of ChromeOS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66f4a7915f135927fbc0a16254dece202dfc23a2
Gerrit-Change-Number: 80769
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Thu, 29 Feb 2024 01:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment