Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74267 )
Change subject: mendocino: Add option to generate FSP version file
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/mendocino/Kconfig:
https://review.coreboot.org/c/coreboot/+/74267/comment/7d4ac03b_5c450868
PS1, Line 488: FSP_VERSION_FILE
Name makes it look like this is a path. I'd suggest slightly different name `INCLUDE_FSP_VERSION_FILE`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c9d322735e0979484b120c665fb100cf187eab
Gerrit-Change-Number: 74267
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 11:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment