Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47724 )
Change subject: mb/google/hatch: add non-ChromeOS FMAPs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47724/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/default-hatch-32MiB.fmd:
https://review.coreboot.org/c/coreboot/+/47724/2/src/mainboard/google/hatch/...
PS2, Line 12:
did you want the SPD cache marked preserve but not the mrc cache?
probably because I created the 16MiB layouts first based on hatch/puff, then copied it and hand-edited the values as needed for the 32MiB ones, and didn't notice the MRC cache was marked preserve on the 32MiB FMAPs. Any reason why the discrepancy between the 16/32MiB FMAPs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ef6ed5b46655b7d283105acdc201b6293bbd1
Gerrit-Change-Number: 47724
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 03:25:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment