Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32347/2/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/gpio.c:
https://review.coreboot.org/#/c/32347/2/src/mainboard/google/sarien/variants...
PS2, Line 110: EDGE_SINGLE
Ideally, we would want to apply level filter at the pad and the interrupt trigger at the APIC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32347
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bee664198057e3997dda181a16b9a0388067036
Gerrit-Change-Number: 32347
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Assignee: Jiayi Lu
jiayi.lu@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Mike Hsieh
mike_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jiayi Lu
jiayi.lu@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:09:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment