Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40020 )
Change subject: sb/intel/bd82x6x: Tidy up code and comments ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 56: .read_byte = lsmbus_read_byte,
Why not stay with tabs?
Because they are completely unnecessary, the alignment difference is a single character.
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/usb_ehci.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 98: .scan_bus = NULL,
Why not `DEVICE_NOOP`?
Paul, that would change the binary.