Attention is currently required from: Tim Wawrzynczak.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48512 )
Change subject: mb/google/volteer: Clean up romstage and ramstage UPDs
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48512/comment/1a82961d_e435eab3
PS5, Line 526: device ref hda on
: probe AUDIO MAX98357_ALC5682I_I2S
: probe AUDIO MAX98373_ALC5682I_I2S
: probe AUDIO MAX98373_ALC5682_SNDW
: probe AUDIO MAX98373_ALC5682I_I2S_UP4
: probe AUDIO MAX98360_ALC5682I_I2S
: end
you missed the RT1011_ALC5682I_I2S codec, which means all boards using that codec now have their HDA device disabled - whoops! Fixed in CB:71150
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d067ff3d181b152c784634ff99202bb2b9202f7
Gerrit-Change-Number: 48512
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Tue, 20 Dec 2022 20:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment