Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39827 )
Change subject: drivers/intel/fsp2_0: Avoid iterative print statement ......................................................................
drivers/intel/fsp2_0: Avoid iterative print statement
This patch keeps "Display FSP Version Info HOB" print outside loop to avoid getting called multiple times.
TEST=Able to see "Display FSP Version Info HOB" only once.
Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39827/1
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index d2c2b78..3978a18 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -233,7 +233,6 @@ (fvih->Count * sizeof (FIRMWARE_VERSION_INFO))); size -= sizeof(SMBIOS_STRUCTURE);
- printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); for (index = 0; index < fvih->Count; index++) { cnt = strlen(str_ptr);
@@ -282,6 +281,7 @@ if (!hob) return;
+ printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { if (hob->type != HOB_TYPE_GUID_EXTENSION)