Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34349 )
Change subject: src/soc/intel/{cnl,icl}: Add support to configure interrupt overrides ......................................................................
Patch Set 3:
(1 comment)
Where is the change to asl code? It needs to go in along with this change, else interrupts would be broken.
https://review.coreboot.org/c/coreboot/+/34349/3/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/34349/3/src/soc/intel/icelake/fsp_p... PS3, Line 248: DevIntConfigPtr This is not right. The pointer is set to 0 by default. You need to provide a pointer to the table in memory where the config is stored by coreboot.