build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating. ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42094/1/src/cpu/amd/pi/00730F01/upd... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/1/src/cpu/amd/pi/00730F01/upd... PS1, Line 132: void amd_update_microcode_from_cbfs() Bad function definition - void amd_update_microcode_from_cbfs() should probably be void amd_update_microcode_from_cbfs(void)
https://review.coreboot.org/c/coreboot/+/42094/1/src/cpu/amd/pi/00730F01/upd... PS1, Line 136: uint16_t equivalent_processor_rev_id = get_equivalent_processor_rev_id(cpuid_eax(1));; Statements terminations use 1 semicolon