EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 12: device ref gna on end
Let's leave this off for now, we may not need it.
okay
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 26: device ref sata on end
Also I'm not aware of using SATA for Brya as of right now
I remember that is HW compatible? Volteer has SATA, I can remove this if we have no plan to support it.